Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(native_dio_adapter): bump cronet_http, cupertino_http dependency #1735

Merged
merged 5 commits into from
Mar 13, 2023
Merged

feat(native_dio_adapter): bump cronet_http, cupertino_http dependency #1735

merged 5 commits into from
Mar 13, 2023

Conversation

knaeckeKami
Copy link
Contributor

@knaeckeKami knaeckeKami commented Mar 12, 2023 •
edited
Loading

New Pull Request Checklist

  • I have read the Documentation
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have updated the documentation (if necessary)
  • I have searched for a similar pull request in the project and found none
  • I have run the tests without failures
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

updates cronet_http and cupertino_http dependencies and updates the code for their breaking changes

@knaeckeKami knaeckeKami requested a review from a team as a code owner March 12, 2023 20:18
ueman
ueman reviewed Mar 12, 2023
View reviewed changes
Copy link
Contributor

@ueman ueman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see you over here

@ueman
Copy link
Contributor

ueman commented Mar 12, 2023

One test is failing, do you mind looking into it?

@knaeckeKami
Copy link
Contributor Author

yes, it looks like the current minimum supported dart version does not work with the latest version of cupertino_http

@knaeckeKami
Copy link
Contributor Author

I bumped the minimum supported flutter version for the flutter plugins (which is only native_dio_adapter it seems?) to 3.7.0 - this should fix the error in the test.

IMO this should be fine since this is an experimental package, but if you have concerns about this just let me know

@kuhnroyal
Copy link
Member

Yea this is the only one, and the example but I guess that's fine.

AlexV525
AlexV525 reviewed Mar 12, 2023
View reviewed changes
plugins/native_dio_adapter/pubspec.yaml Outdated
@@ -6,13 +6,13 @@ repository: https://github.com/cfug/dio/blob/main/plugins/native_dio_adapter
issue_tracker: https://github.com/cfug/dio/issues

environment:
sdk: '>=2.18.0 <3.0.0'
sdk: '>=2.19.0 <3.0.0'
flutter: ">=3.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider update the Flutter constraint too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ueman
Copy link
Contributor

ueman commented Mar 13, 2023

We should release this as 0.1.0 because it's somewhat breaking because of the raised Dart/Flutter versions as well as the raised versions of the cupertino and cronet clients

@knaeckeKami @AlexV525
Update plugins/native_dio_adapter/CHANGELOG.md
ba5eb97 
Co-authored-by: Alex Li <github@alexv525.com>
Signed-off-by: Martin Kamleithner <martin.kamleithner@gmail.com>
@AlexV525
Copy link
Member

We should release this as 0.1.0 because it's somewhat breaking because of the raised Dart/Flutter versions as well as the raised versions of the cupertino and cronet clients

Sure, just write native_dio_adapter: v0.1.0 in the release issue and the bot will do it for you. 😄

@ueman ueman merged commit ba91ed7 into cfug:main Mar 13, 2023
@AlexV525
Copy link
Member

Oh it seems the bot didn't take good care of Flutter plugins. I'll schedule another run once it's resolved.

@ueman
Copy link
Contributor

ueman commented Mar 13, 2023

Oh it seems the bot didn't take good care of Flutter plugins. I'll schedule another run once it's resolved.

Thank you

@AlexV525
Copy link
Member

v0.1.0 is up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexV525 AlexV525 AlexV525 approved these changes

@ueman ueman ueman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@knaeckeKami @ueman @kuhnroyal @AlexV525